This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
refactor: remove async module #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
3 tasks
AVaksman
changed the title
Update samples to use async/await. Uptate main system tests to use async/await and callback versions.
AVaksman
force-pushed
the
remove-async-module
branch
from
7fc4f7a to
6ad4594
Compare
AVaksman
changed the title
ajaaym
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
JustinBeckwith
changed the title
JustinBeckwith
suggested changes
Jan 15, 2019
JustinBeckwith
approved these changes
Jan 22, 2019
system-test/test.ts
Outdated
| const images = is as ImageMap; | ||
| assert.ifError(err); | ||
| it('should get only the latest image from every OS', async () => { | ||
| try { |
There was a problem hiding this comment.
No need to do the try/catch here, it'll just fail if it throws :)
There was a problem hiding this comment.
True, thanks, done.
system-test/test.ts
Outdated
| }); | ||
| assert(image.selfLink.indexOf(osName) > -1); | ||
| } catch (err) { | ||
| assert.ifError(err); |
There was a problem hiding this comment.
same here, you can just drop this
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards googleapis/google-cloud-node/issues/2883
asyncandpifymodules.chaiforasserts.asyncfirst with callbackification support rather than usingpromisifyAll.