From c7f63bd270d81f75abdf0282bd3c4be4de02bdbd Mon Sep 17 00:00:00 2001 From: Anthonios Partheniou Date: Fri, 13 Oct 2023 16:59:44 +0000 Subject: [PATCH] Address review comments --- google/api_core/bidi.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/google/api_core/bidi.py b/google/api_core/bidi.py index 17d9fc9f..0eb4a5dc 100644 --- a/google/api_core/bidi.py +++ b/google/api_core/bidi.py @@ -265,6 +265,9 @@ def add_done_callback(self, callback): self._callbacks.append(callback) def _on_call_done(self, future): + # Note that grpc's "future" here is also a grpc.RpcError. + # `grpc.RpcError` is also `grpc.call` based on + # https://github.com/grpc/grpc/issues/10885#issuecomment-302651331 for callback in self._callbacks: callback(future)