Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: revert testing against prerelease deps on Python 3.9 #426

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 17, 2021

Reverts #415

Consensus from today's meeting is that testing prereleases of third-party dependencies needs to happen outside the normal presubmit path.

@tseaver tseaver requested review from tswast, crwilcox, busunkim96 and a team August 17, 2021 18:01
@tseaver tseaver requested a review from a team as a code owner August 17, 2021 18:01
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Aug 17, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 17, 2021
@tseaver tseaver changed the title Revert "tests: allow prerelease deps on Python 3.9" tests: revert testsing against prerelease deps on Python 3.9 Aug 17, 2021
@tseaver tseaver changed the title tests: revert testsing against prerelease deps on Python 3.9 tests: revert testing against prerelease deps on Python 3.9 Aug 17, 2021
@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Aug 18, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit cf9cddb into master Aug 18, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the revert-415-414-test-against-prerelease-deps-under-3.9 branch August 18, 2021 16:12
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants