From 5a5024727b93d0ba557b6f7ee5c6c1bab8d723d6 Mon Sep 17 00:00:00 2001
From: Jeff Ching <chingor@google.com>
Date: Mon, 11 Sep 2023 13:30:54 -0700
Subject: [PATCH] feat!: require node 18+ (#2069)

---
 .github/workflows/ci.yaml | 7 +------
 package.json              | 4 ++--
 2 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index aa2379d4e..77311560e 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -9,15 +9,12 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [14, 16, 18]
+        node: [18, 20]
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node }}
-      - name: Override NODE options for the most recent version
-        if: matrix.node == '18'
-        run: echo "NODE_OPTIONS=--no-experimental-fetch" >> $GITHUB_ENV
       - run: node --version
       # The first installation step ensures that all of our production
       # dependencies work on the given Node.js version, this helps us find
@@ -36,8 +33,6 @@ jobs:
       - uses: actions/setup-node@v3
         with:
           node-version: 18
-      - name: Override NODE options for the most recent version
-        run: echo "NODE_OPTIONS=--no-experimental-fetch" >> $env:GITHUB_ENV
       - run: npm install
       - run: npm test
         env:
diff --git a/package.json b/package.json
index afee9b0d9..b1626822d 100644
--- a/package.json
+++ b/package.json
@@ -5,7 +5,7 @@
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",
   "scripts": {
-    "test": "cross-env ENVIRONMENT=test LC_ALL=en c8 mocha --recursive --timeout=5000 build/test",
+    "test": "cross-env ENVIRONMENT=test LC_ALL=en c8 mocha --node-option no-experimental-fetch --recursive --timeout=5000 build/test",
     "docs": "echo add docs tests",
     "test:snap": "SNAPSHOT_UPDATE=1 LC_ALL=en npm test",
     "clean": "gts clean",
@@ -104,6 +104,6 @@
     "yargs": "^17.0.0"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=18.0.0"
   }
 }