From dad27e385e4cfdec18c84a1b48c3b45ab65abe5e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bazyli=20Brz=C3=B3ska?= <bazyli.brzoska@gmail.com>
Date: Wed, 11 Sep 2024 10:04:53 -0700
Subject: [PATCH] fix: respect `tagSeparator` and `includeVInTag` everywhere
 (#2283)

fixes #2282

Co-authored-by: Jeff Ching <chingor@google.com>
---
 src/manifest.ts             | 7 ++++++-
 src/strategies/php-yoshi.ts | 7 ++++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/manifest.ts b/src/manifest.ts
index ec227dc6c..5226ac21f 100644
--- a/src/manifest.ts
+++ b/src/manifest.ts
@@ -687,7 +687,12 @@ export class Manifest {
           `No latest release found for path: ${path}, component: ${component}, but a previous version (${version.toString()}) was specified in the manifest.`
         );
         releasesByPath[path] = {
-          tag: new TagName(version, component),
+          tag: new TagName(
+            version,
+            component,
+            this.repositoryConfig[path].tagSeparator,
+            this.repositoryConfig[path].includeVInTag
+          ),
           sha: '',
           notes: '',
         };
diff --git a/src/strategies/php-yoshi.ts b/src/strategies/php-yoshi.ts
index ed31687b9..8bd1bfde6 100644
--- a/src/strategies/php-yoshi.ts
+++ b/src/strategies/php-yoshi.ts
@@ -101,7 +101,12 @@ export class PHPYoshi extends BaseStrategy {
     const versionsMap: VersionsMap = new Map();
     const directoryVersionContents: Record<string, ComponentInfo> = {};
     const component = await this.getComponent();
-    const newVersionTag = new TagName(newVersion, component);
+    const newVersionTag = new TagName(
+      newVersion,
+      component,
+      this.tagSeparator,
+      this.includeVInTag
+    );
     let releaseNotesBody = `## ${newVersion.toString()}`;
     for (const directory of topLevelDirectories) {
       try {