From eb968c8cbbf666355b87612e3bb704e1611e1747 Mon Sep 17 00:00:00 2001
From: Ketil <477141+mysteq@users.noreply.github.com>
Date: Wed, 11 Sep 2024 18:57:12 +0200
Subject: [PATCH] fix: respect signoff in manifest config (#2334)

Signed-off-by: Ketil Gjerde <477141+mysteq@users.noreply.github.com>
Co-authored-by: Jeff Ching <chingor@google.com>
---
 schemas/config.json | 5 +++++
 src/manifest.ts     | 5 ++---
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/schemas/config.json b/schemas/config.json
index 80056c466..e47aae6df 100644
--- a/schemas/config.json
+++ b/schemas/config.json
@@ -396,6 +396,10 @@
             ]
           }
         },
+        "signoff": {
+          "description": "Text to be used as Signed-off-by in the commit.",
+          "type": "string"
+        },
         "group-pull-request-title-pattern": {
           "description": "When grouping multiple release pull requests use this pattern for the title.",
           "type": "string"
@@ -431,6 +435,7 @@
     "last-release-sha": true,
     "always-link-local": true,
     "plugins": true,
+    "signoff": true,
     "group-pull-request-title-pattern": true,
     "release-search-depth": true,
     "commit-search-depth": true,
diff --git a/src/manifest.ts b/src/manifest.ts
index 341e7ff85..ec227dc6c 100644
--- a/src/manifest.ts
+++ b/src/manifest.ts
@@ -121,7 +121,6 @@ export interface ReleaserConfig {
   releaseLabels?: string[];
   extraLabels?: string[];
   initialVersion?: string;
-  signoff?: string;
 
   // Changelog options
   changelogSections?: ChangelogSection[];
@@ -161,7 +160,6 @@ interface ReleaserConfigJson {
   'changelog-sections'?: ChangelogSection[];
   'release-as'?: string;
   'skip-github-release'?: boolean;
-  signoff?: string;
   draft?: boolean;
   prerelease?: boolean;
   'draft-pull-request'?: boolean;
@@ -255,6 +253,7 @@ export interface ManifestConfig extends ReleaserConfigJson {
   'last-release-sha'?: string;
   'always-link-local'?: boolean;
   plugins?: PluginType[];
+  signoff?: string;
   'group-pull-request-title-pattern'?: string;
   'release-search-depth'?: number;
   'commit-search-depth'?: number;
@@ -1372,7 +1371,6 @@ function extractReleaserConfig(
     skipSnapshot: config['skip-snapshot'],
     initialVersion: config['initial-version'],
     excludePaths: config['exclude-paths'],
-    signoff: config['signoff'],
   };
 }
 
@@ -1417,6 +1415,7 @@ async function parseConfig(
     separatePullRequests: config['separate-pull-requests'],
     groupPullRequestTitlePattern: config['group-pull-request-title-pattern'],
     plugins: config['plugins'],
+    signoff: config['signoff'],
     labels: configLabel?.split(','),
     releaseLabels: configReleaseLabel?.split(','),
     snapshotLabels: configSnapshotLabel?.split(','),