Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update java-shared-config to v1.7.3 #2512

Closed
wants to merge 2 commits into from

Conversation

mpeddada1
Copy link
Contributor

Investigation of renovate-bot being unable to update this dependency at #2511

@mpeddada1 mpeddada1 requested a review from a team as a code owner February 27, 2024 21:28
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 27, 2024
Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Feb 27, 2024

Running into the following erorr for java-spanner-jdbc downstream check:

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile (default-testCompile) on project google-cloud-spanner-jdbc: Compilation failure: Compilation failure: 
Error:  /home/runner/work/sdk-platform-java/sdk-platform-java/java-shared-dependencies/target/java-spanner-jdbc/src/test/java/com/google/cloud/spanner/jdbc/StatementReturnGeneratedKeysMockServerTest.java:[318,29] cannot find symbol
Error:    symbol:   method pack(com.google.protobuf.Empty)
Error:    location: class com.google.protobuf.Any
Error:  /home/runner/work/sdk-platform-java/sdk-platform-java/java-shared-dependencies/target/java-spanner-jdbc/src/test/java/com/google/cloud/spanner/jdbc/StatementReturnGeneratedKeysMockServerTest.java:[319,29] cannot find symbol
Error:    symbol:   method pack(com.google.spanner.admin.database.v1.UpdateDatabaseDdlMetadata)
Error:    location: class com.google.protobuf.Any
Error:  /home/runner/work/sdk-platform-java/sdk-platform-java/java-shared-dependencies/target/java-spanner-jdbc/src/test/java/com/google/cloud/spanner/jdbc/PreparedStatementReturnGeneratedKeysMockServerTest.java:[318,29] cannot find symbol

@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Feb 27, 2024

Running the checks from main however results in a successful build: #2513. It also uses maven-compiler-plugin:3.11.0:compile

@burkedavison
Copy link
Member

Both GraalVM test shows (many) KMS failures that look the same as in java-spanner.
https://source.cloud.google.com/results/invocations/8de16815-7841-4778-b7b2-5d4a73b02211

Example failure:

Warning: Could not register com.google.cloud.location.Location$Builder: queryAllPublicConstructors for reflection. Reason: java.lang.VerifyError: Bad type on operand stack
Exception Details:
  Location:
    com/google/cloud/location/Location$Builder.setMetadata(Lcom/google/protobuf/Any$Builder;)Lcom/google/cloud/location/Location$Builder; @26: invokevirtual
  Reason:
    Type 'com/google/protobuf/Any' (current frame, stack[1]) is not assignable to 'com/google/protobuf/AbstractMessage'
  Current Frame:
    bci: @26
    flags: { }
    locals: { 'com/google/cloud/location/Location$Builder', 'com/google/protobuf/Any$Builder' }
    stack: { 'com/google/protobuf/SingleFieldBuilderV3', 'com/google/protobuf/Any' }
  Bytecode:
    0000000: 2ab4 001f c700 0e2a 2bb6 0076 b500 1ea7
    0000010: 000f 2ab4 001f 2bb6 0076 b600 7557 2a59
    0000020: b400 1c10 1080 b500 1c2a b600 3d2a b0  
  Stackmap Table:
    same_frame(@18)
    same_frame(@30)

@zhumin8
Copy link
Contributor

zhumin8 commented Feb 28, 2024

Hit same error with java-shared-config v 1.7.2 (without graal-sdk to v22.3.5 upgrade): workflow logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants