chore: add a log in config checker #2696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeWang1127
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
blakeli0
reviewed
Apr 29, 2024
| @@ -161,6 +161,7 @@ def validate_generation_config(generation_config_path: str) -> None: | |||
| generation_config_path = "generation_config.yaml" | |||
| try: | |||
| from_yaml(os.path.abspath(generation_config_path)) | |||
| print(f"{generation_config_path} is validated without error.") | |||
There was a problem hiding this comment.
Suggested change
| print(f"{generation_config_path} is validated without error.") | |
| print(f"{generation_config_path} is validated without any errors.") |
blakeli0
approved these changes
Apr 29, 2024
JoeWang1127
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
|
|
lqiu96
pushed a commit
that referenced
this pull request
May 22, 2024
In this PR: - Add a log when the config validation succeeds. Context: I tested the checker in [here](https://github.com/googleapis/google-cloud-java/actions/runs/8884272073/job/24392990025?pr=10761). It will be good if the checker emit a log when the check passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Context: I tested the checker in here. It will be good if the checker emit a log when the check passed.