Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a log in config checker #2696

Merged
merged 2 commits into from
Apr 29, 2024
Merged

chore: add a log in config checker #2696

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa84ec4
chore: add a log in config checker
JoeWang1127 Apr 29, 2024
6cac967
change message
JoeWang1127 Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions library_generation/cli/entry_point.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ def validate_generation_config(generation_config_path: str) -> None:
generation_config_path = "generation_config.yaml"
try:
from_yaml(os.path.abspath(generation_config_path))
print(f"{generation_config_path} is validated without error.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print(f"{generation_config_path} is validated without error.")
print(f"{generation_config_path} is validated without any errors.")

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

except ValueError as err:
print(err)
sys.exit(1)
Expand Down
Loading