From 7b1a7d11f0b3f7a5fa91efe6f14f5f7082ebd500 Mon Sep 17 00:00:00 2001 From: sofisl <55454395+sofisl@users.noreply.github.com> Date: Mon, 10 Jul 2023 13:43:33 -0700 Subject: [PATCH 1/2] build: add extra test for Node 20, update windows tests --- synthtool/gcp/templates/node_library/.github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/synthtool/gcp/templates/node_library/.github/workflows/ci.yaml b/synthtool/gcp/templates/node_library/.github/workflows/ci.yaml index 8730b393c..19d95c76e 100644 --- a/synthtool/gcp/templates/node_library/.github/workflows/ci.yaml +++ b/synthtool/gcp/templates/node_library/.github/workflows/ci.yaml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node: [{{metadata['engine'] | int}}, {{metadata['engine'] | int+2}}, {{metadata['engine'] | int+4}}] + node: [{{metadata['engine'] | int}}, {{metadata['engine'] | int+2}}, {{metadata['engine'] | int+4}}, {{metadata['engine'] | int+6}}] steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 From 5d5bb44e45318f167ee53a983551c3116bc47396 Mon Sep 17 00:00:00 2001 From: sofisl <55454395+sofisl@users.noreply.github.com> Date: Mon, 10 Jul 2023 13:45:04 -0700 Subject: [PATCH 2/2] Update test.bat --- synthtool/gcp/templates/node_library/.kokoro/test.bat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/synthtool/gcp/templates/node_library/.kokoro/test.bat b/synthtool/gcp/templates/node_library/.kokoro/test.bat index ae59e59be..0bb124052 100644 --- a/synthtool/gcp/templates/node_library/.kokoro/test.bat +++ b/synthtool/gcp/templates/node_library/.kokoro/test.bat @@ -21,7 +21,7 @@ cd .. @rem we upgrade Node.js in the image: SET PATH=%PATH%;/cygdrive/c/Program Files/nodejs/npm -call nvm use v12.14.1 +call nvm use v14.17.3 call which node call npm install || goto :error