Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Commit b0f5c2d

Browse files
authored
Explicitly configure gcloud to use the test project in release validation. (#1154)
This change switches the release script from specifying the test project via the 'PROJECT_ID' environment variable to instead setting the project via the 'CLOUDSDK_CORE_PROJECT' environment varialbe. This is necessary because googledatalab/pydatalab#136 changed the pydatalab library so that the gcloud config overrides the 'PROJECT_ID' environment variable. This means that in a GCE VM, we don't use that variable, as gcloud will pick up the project name from the metadata server. However, gcloud itself will use the 'CLOUDSDK_CORE_PROJECT' variable, so we use that one for setting the test project.
1 parent 690b9f4 commit b0f5c2d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/release/publish.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ git clone https://github.com/googledatalab/notebooks tests/notebooks
4949
docker run \
5050
--net host \
5151
-v "$(pwd)/tests:/content/datalab" \
52-
-e "PROJECT_ID=${TEST_PROJECT_ID}" \
52+
-e "CLOUDSDK_CORE_PROJECT=${TEST_PROJECT_ID}" \
5353
--entrypoint /content/datalab/notebooks/.test.sh \
5454
--workdir /content/datalab/notebooks \
5555
${DATALAB_IMAGE}

0 commit comments

Comments
 (0)