Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 - refactoring #88

Open
inhere opened this issue Mar 16, 2021 · 0 comments
Open

V2 - refactoring #88

inhere opened this issue Mar 16, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@inhere
Copy link
Member

inhere commented Mar 16, 2021

old:

// Gt check value greater dst value. only check for: int(X), uint(X), float(X)
func Gt(val interface{}, dstVal int64) bool {

v2 new:

// Gt check value greater dst value. only check for: int(X), uint(X), float(X)
func Gt(val, dstVal interface{}) bool {
	return gt(reflect.ValueOf(val), reflect.ValueOf(dstVal))
}

// internal implements
func gt(val reflect.Value, dstVal reflect.Value) bool
@inhere inhere added this to the V2 - refacting milestone Mar 16, 2021
@inhere inhere self-assigned this Mar 16, 2021
@inhere inhere added enhancement New feature or request help wanted Extra attention is needed labels Mar 25, 2021
@inhere inhere changed the title V2 - refacting V2 - refactoring Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant