Skip to content
This repository has been archived by the owner on Nov 15, 2017. It is now read-only.

Own block rules lost after update to v. 1.0.0.3 #381

Closed
ghost opened this issue Jul 23, 2014 · 7 comments
Closed

Own block rules lost after update to v. 1.0.0.3 #381

ghost opened this issue Jul 23, 2014 · 7 comments

Comments

@ghost
Copy link

ghost commented Jul 23, 2014

Unfortunately, the "Your block rules" window is empty now. I assume that this problem might be related to the FileSystem API change?

@gorhill
Copy link
Owner

gorhill commented Jul 23, 2014

Crap.

I just reviewed the code and I can't see why it wouldn't work. Will keep looking but it's kind of too late at this point, there is no way back.

If you have a back up, restoring should work fine though.

@ghost
Copy link
Author

ghost commented Jul 23, 2014

Yes, I was able to restore them.

BTW, I forgot to mention that I also have some allow rules in ABP syntax which I forgot to remove in HTTPSB - they "survived".

@gorhill
Copy link
Owner

gorhill commented Jul 23, 2014

Ok so if I understand, before the restore, the block rules were gone, while the allow rules were properly converted to the new storage?

@ghost
Copy link
Author

ghost commented Jul 23, 2014

Ok so if I understand, before the restore, the block rules were gone,
while the allow rules were properly converted to the new storage?

Exactly!

@gorhill
Copy link
Owner

gorhill commented Jul 23, 2014

Ok. I see potential for a race condition, where there is an attempt to load data before it has been saved. If so, this means that your data was properly converted, but somehow the actual writing of bytes to the storage did not occur before the data was requested.

I need to fix this.

The workaround meanwhile in case other users end up with the same problem is a simple restart of the extension (disabling/enabling).

@ghost
Copy link
Author

ghost commented Jul 23, 2014

The workaround meanwhile in case other users end up with the same
problem is a simple restart of the extension (disabling/enabling).

I didn't think of this workaround. Too late to test it now ...

@gorhill
Copy link
Owner

gorhill commented Jul 23, 2014

Actually, correction:

The data was irremediably lost. Whichever "block" or "allow" rules was saved first was clobbered if both fields had rules.

I can still save Opera users I think.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant