Skip to content

Commit

Permalink
fix #2963
Browse files Browse the repository at this point in the history
  • Loading branch information
gorhill committed Nov 12, 2017
1 parent 77334bf commit 48f65f1
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/js/messaging.js
Original file line number Diff line number Diff line change
Expand Up @@ -493,9 +493,7 @@ var onMessage = function(request, sender, callback) {
if ( pageStore && pageStore.getNetFilteringSwitch() ) {
response = {
collapseBlocked: µb.userSettings.collapseBlocked,
noCosmeticFiltering:
µb.cosmeticFilteringEngine.acceptedCount === 0 ||
pageStore.noCosmeticFiltering === true,
noCosmeticFiltering: pageStore.noCosmeticFiltering === true,
noGenericCosmeticFiltering:
pageStore.noGenericCosmeticFiltering === true
};
Expand Down

2 comments on commit 48f65f1

@okiehsch
Copy link
Contributor

@okiehsch okiehsch commented on 48f65f1 Nov 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue if I have 0 cosmetic filters enabled, but I can still reproduce if I toggle off cosmetic filtering.
Firefox 57; uBO 1.14.19b7

@gorhill
Copy link
Owner Author

@gorhill gorhill commented on 48f65f1 Nov 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I focused on fixing the reported issue specifically. For the toggle cosmetic filtering switch, it's more complicated, since the element picker still has to work, but partially, only to create network filters. This will need lots of changes in elementpicker.js.

Please sign in to comment.