-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox + whitelisting and "Private mode" leak information #104
Comments
I don't think private mode was meant to keep extensions from saving their own data, just to keep ordinary website data from being saved, like cookies and cache; this, BTW, is why extensions are disabled by default in Chrome's Incognito mode and you need to check the box under every extension you want to allow in that mode (and you need to turn on the "Developer" view in the Extensions menu just to see the checkboxes). |
@Armonth and other users who don't want changes to be permanent can just use the green column of dynamic filtering pane to whitelist whatever they want, including full sites, and then revert back with the eraser icon or close the browser without saving the changes. As @lewisje pointed out, extensions are supposed to work normally on private mode, and changing that would be terrible for other users. I use Private Tabs to browse many sites only in private mode and don't want uBlock to stop working as expected on them. Some of my several custom searches/bookmarks with keywords that open in private tabs: |
The dynamic filtering pane suggested by @anewuser is only available for advanced users, but it's the rest of the users that need protection the most. Would it be possible and reasonable for the simple on/off functionality to use that same dynamic filtering logic? That is, the existing whitelist is respected, whitelist changes are kept in memory, an option is provided to save the whitelist. When an explicit "Save" button is clicked, a user should be able to understand that this will continue to be visible after leaving private browsing mode. |
…ble-flag Add a master switch for HTML filtering
A long time ago, in Firefox was considered as one bug that "autofill" worked in private mode/other profiles because can 'filter' information of what webs you visit.
Now want to put a similar issue with uBlock:
Expected behavior: forget sites whitelisted in private mode when close the session.
The text was updated successfully, but these errors were encountered: