Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox + whitelisting and "Private mode" leak information #104

Closed
Armonth opened this issue Apr 20, 2015 · 3 comments
Closed

Firefox + whitelisting and "Private mode" leak information #104

Armonth opened this issue Apr 20, 2015 · 3 comments
Labels

Comments

@Armonth
Copy link

Armonth commented Apr 20, 2015

A long time ago, in Firefox was considered as one bug that "autofill" worked in private mode/other profiles because can 'filter' information of what webs you visit.

Now want to put a similar issue with uBlock:

  1. Enter private mode.
  2. Go to one site you don't want to allow others users of the PC to know you visit (yeah, you thinked same as me, but no: i'm talking of my online bank site 😉)
  3. Disable uBlock for that site (because that online bank site is stupid and something is blocked by a generic filter).
  4. Close private mode.
  5. That site is still whitelisted in uBlock settings... so people can have access to information you don't wanto they to know.

Expected behavior: forget sites whitelisted in private mode when close the session.

@lewisje
Copy link

lewisje commented Apr 21, 2015

I don't think private mode was meant to keep extensions from saving their own data, just to keep ordinary website data from being saved, like cookies and cache; this, BTW, is why extensions are disabled by default in Chrome's Incognito mode and you need to check the box under every extension you want to allow in that mode (and you need to turn on the "Developer" view in the Extensions menu just to see the checkboxes).

@anewuser
Copy link
Contributor

anewuser commented Jan 8, 2016

@Armonth and other users who don't want changes to be permanent can just use the green column of dynamic filtering pane to whitelist whatever they want, including full sites, and then revert back with the eraser icon or close the browser without saving the changes.

As @lewisje pointed out, extensions are supposed to work normally on private mode, and changing that would be terrible for other users. I use Private Tabs to browse many sites only in private mode and don't want uBlock to stop working as expected on them. Some of my several custom searches/bookmarks with keywords that open in private tabs:

untitled-1

@hvdijk
Copy link

hvdijk commented Oct 23, 2016

The dynamic filtering pane suggested by @anewuser is only available for advanced users, but it's the rest of the users that need protection the most. Would it be possible and reasonable for the simple on/off functionality to use that same dynamic filtering logic? That is, the existing whitelist is respected, whitelist changes are kept in memory, an option is provided to save the whitelist. When an explicit "Save" button is clicked, a user should be able to understand that this will continue to be visible after leaving private browsing mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants