Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsupported genericblock causes supported generichide to be ignored #2283

Closed
okiehsch opened this issue Jan 2, 2017 · 1 comment
Closed

Unsupported genericblock causes supported generichide to be ignored #2283

okiehsch opened this issue Jan 2, 2017 · 1 comment

Comments

@okiehsch
Copy link
Contributor

okiehsch commented Jan 2, 2017 •
edited
Loading

Describe the issue

uBlock does not enforce a filter with a generichide rule, if it is accompanied by a
genericblock rule, probably because it doesn't support genericblock.
This effects some rules in Easylistgermany, for example.
@@||spiegel.de^$genericblock,generichide
@@||tellows.de^$genericblock,generichide

Steps for anyone to reproduce the issue

  1. Add @@||github.com^$generichide to your filter list

  2. Go to github.com

  3. Logger as expected
    gith

  4. If you add @@||github.com^$genericblock,generichide instead
    github1

Your settings

  • Browser/version: Chrome 55
  • uBlock Origin version: 1.10.4
Your filter lists

default
@lewisje
Copy link

lewisje commented Jan 3, 2017

I guess the genericblock option should be ignored rather than causing the whole filter to be rejected: #967 (comment)

@gorhill gorhill changed the title generichide rule problem Unsupported genericblock causes supported generichide to be ignored Sep 14, 2017
@okiehsch okiehsch mentioned this issue Sep 22, 2017
Closed
gorhill added a commit that referenced this issue Jan 13, 2018
@gorhill
fix #2283
605dcc9
gorhill added a commit that referenced this issue Nov 30, 2020
@gorhill
Fix the parsing of unsupported static network filter types
391a5c9 
Related issue:
- #2283

This is a regression causing the referenced issue to no
longer be fixed. The regression was introduced when the
new static filtering parser code was introduced in version
1.28.0:

https://github.com/gorhill/uBlock/releases/tag/1.28.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lewisje @okiehsch