Filters converted from Adguard are shown incorrectly in the logger

[hant0508]

Describe the issue

The filter list from which the filter was taken isn't shown in the logger.

Screenshot in which the issue can be seen

Steps for anyone to reproduce the issue

1. Subscribe to Adguard Annoyances Filter or add this to your filters: google.ru#$#.pdp-psy > .gb_Lc.gb_g[data-ved]{display:none!important;}
2. Visit https://google.ru
3. Open the logger and find there ##.pdp-psy > .gb_Lc.gb_g[data-ved]:style(display:none!important;)

Your settings

• OS/version: Debian GNU/Linux
• Browser/version: Mozilla Firefox 53.0.3
• uBlock Origin version: 1.12.5b17

[hant0508]

The same issue with global hiding filters starting with ~, e.g. ~example.com##div.

[hant0508]

And one more case: hiding filters that contain several domains are shown correctly only on the last domain in a list. For example, rbc.ru,yandex.com,yandex.ru##.banner is shown in logger only on yandex.ru.

[gorhill]

Actually, all this is by design, not a new behavior: uBO shows you the normalized version of a filter, not the raw, un-parsed version.

So ~example.com##div is normalized to:

##div
example.com#@#div

While rbc.ru,yandex.com,yandex.ru##.banner is normalized to:

rbc.ru##.banner
yandex.com##.banner
yandex.ru##.banner

And uBO won't report these filters in the logger if the element(s) they target is not found on the page.

[hant0508]

I describe the situation when the elements are found on the page and it's reported in the logger, but user can't see any information about this filter (like on the screenshot).

There are elements named .banner on both pages rbc.ru and yandex.ru, so filter rbc.ru,yandex.ru##.banner will work on them and it will be reported in the logger, but it will be correctly reported only on the yandex.ru. And vice versa, yandex.ru,rbc.ru##.banner will show empty white rectangle on yandex.ru and will report the information correctly on rbc.ru.

[gorhill]

white rectangle on yandex.ru

I can't get the yandex.ru to report something about .banner, and using the dev console document.querySelector('.banner'); returns null.

[gorhill]

Ok never mind, I swapped yandex.ru and rbc.ru and went to http://www.rbc.ru/ and can now reproduce the issue.

[hant0508]

Just tested it on rbc.ru:

1. rbc.ru##.banner

2. yandex.ru,rbc.ru##.banner

3. rbc.ru,yandex.ru##.banner

I can't get the yandex.ru to report something about .banner

My mistake, there's a ###banner on yandex.ru, but the same problem occurs. An example filter rbc.ru,yandex.com,yandex.ru##.banner was taken as a part of a very long filter form Adguard Russian Filters.

[hant0508]

uBO shows you the normalized version of a filter, not the raw, un-parsed version.

So there's one more issue with the logger.

1. Subscribe to RUS: RU AdList
2. Visit https://rsload.net
3. Open the logger and find csp

[Halibut80]

So there's one more issue with the logger.

@hant05080 Maybe you need to fill separate issue for that?

As temporally fix, style for Stylish/userContent.css:

@namespace url(http://www.w3.org/1999/xhtml);

@-moz-document url-prefix("chrome://ublock0/content/logger-ui.html") {
    #filterFinderDialog .dialog code {
        max-height: 40vh !important;
        overflow: auto !important;
        display: inline-block !important;
        vertical-align: -6px !important;
    }
}

[gwarser]

2c9c98e introduced regression in logger.
On my system (Firefox ~85k cosmetic filters) up to 7 seconds is needed for cosmetic filter details layer/dialog to appear after I click on it.

In Chromium, this is about 2s.

[gorhill]

Does the 7-second delay occur only the first time you lookup the filter, or does it happens also if you lookup again immediately?

[gwarser]

Happens every time, but may be little random in length - more like between 4 and 10 seconds.

This is visible in Chromium profiler in worker thread as regex.

Also on my phone, this is like 40 seconds! :(

I found this commit by git bisect, then "Load Temporary Add-on" in about:debugging in Firefox ESR.

For simple filter: