Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUGGESTION] Add Adguard Spanish/Portuguese filter #3089

Closed
rd-su opened this issue Oct 3, 2017 · 2 comments
Closed

[SUGGESTION] Add Adguard Spanish/Portuguese filter #3089

rd-su opened this issue Oct 3, 2017 · 2 comments

Comments

@rd-su
Copy link

rd-su commented Oct 3, 2017

I would like to suggest adding the "Adguard Spanish/Portuguese filter"(https://kb.adguard.com/en/general/adguard-ad-filters#spanish).

Thanks

@rd-su rd-su changed the title [SUGGESTION] Add AdGuard Spanish/Portuguese filter [SUGGESTION] Add Adguard Spanish/Portuguese filter Oct 3, 2017
@gorhill
Copy link
Owner

gorhill commented Oct 4, 2017

@ameshkov I see filters of the following form in there:

||mundome.com^$popup,image,~image

What is the purpose of declaring/undeclaring image type in the same filter?

@ameshkov
Copy link

ameshkov commented Oct 4, 2017

As it's stated in the filter description, it was originally forked from Fanboy's Spanish, and these rules seem to be leftover from it. This odd modifiers usage reminds me of an old bug of ABP which required it.

Anyways, I don't see why we'd need these rules now, removed them from the filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants