-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Element picker/zapper don't work if cosmetic filtering is disabled #3212
Comments
|
My mistake, this is not a duplicate. |
I can reproduce it in Chromium 66 too. |
The element picker for me does not working at all. Just tested it on a fresh Firefox profile, installed uBlock and it's not working. |
8 tasks
8 tasks
8 tasks
8 tasks
8 tasks
Closed
8 tasks
8 tasks
5 tasks
gorhill
changed the title
Element picker/zapper don't work if cosmetic filtering is disabled (Firefox 52 ESR / uBO 1.14.17+)
Element picker/zapper don't work if cosmetic filtering is disabled
Mar 24, 2019
gorhill
referenced
this issue
Sep 21, 2019
Related documentation: - https://help.eyeo.com/en/adblockplus/how-to-write-filters#element-hiding Related feedback/discussion: - https://www.reddit.com/r/uBlockOrigin/comments/d6vxzj/ The `elemhide` filter option as per ABP semantic is now supported. Previously uBO would consider `elemhide` to be an alias of `generichide`. The support of `elemhide` is through the convenient conversion of `elemhide` option into existing `generichide` option and new `specifichide` option. The purpose of the new `specifichide` filter option is to disable all specific cosmetic filters, i.e. those who target a specific site. Additionally, for convenience purpose, the filter options `generichide`, `specifichide` and `elemhide` can be aliased using the shorter forms `ghide`, `shide` and `ehide` respectively.
This was referenced Feb 8, 2020
8 tasks
8 tasks
gorhill
added a commit
that referenced
this issue
Jul 12, 2021
Related issue: - #3212 The element picker will now properly work on sites where cosmetic filtering is disabled, but will not allow the creation of cosmetic filters when specific cosmetic filters are not meant to be enforced in the current page. When specific cosmetic filters are not meant to be enforced, the element picker will still allow the creation of network filters, that is unless the current page is trusted, in which case using the element picker is pointless.
Closed
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the issue
Disabling cosmetic filtering by default will prevent the element picker and zapper from manifesting, when called from either toolbar icon or context menu.
Verified by creating new profile, changing the add-on signature requirement in about:config, installing uBO and toggling the cosmetic filtering setting. No further changes from default Firefox or uBO configuration.
One or more specific URLs where the issue occurs
https://github.com/gorhill/uBlock/releases
Steps for anyone to reproduce the issue
Your settings
The text was updated successfully, but these errors were encountered: