-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$generichide and $genericblock now in ABP #967
Comments
I am going to wait for an official release of ABP version with support for these filter options and see how often used and how useful they are before making a decision. |
For the time being I will decline implementing From what I see, this is ABP answer to some anti-blocker mechanisms, and I disagree with the approach: ABP's solution to work around anti-blocker mechanisms is to punch holes into the blocking filters, i.e. to block less. This is not a pro-users solution. When time allows, I will be running comparative benchmarks to demonstrate this. |
Will it be possible to support it as a user side setting? |
If you don't plan to support them, they should at least be mentioned in the Wiki; both options exist only for whitelist rules: https://adblockplus.org/development-builds/new-filter-options-generichide-and-genericblock
$generichide
is like$elemhide
except that it disables only generic hiding rules, meaning hiding rules with no domain specifiers, or "with a few exceptions" (I might need to look into the code to see what is meant by "a few" but for now it looks like "a few" means "fewer than 1").$genericblock
is like$document
except that it disables only generic blocking rules, meaning blocking rules with no$domain
or$sitekey
option, or "with a few exceptions" (in the same sense as above) in the$domain
option.The purpose of these experimental options is to whitelist the common generic rules that anti-adblock technology tests against, without painstakingly doing so on a script-by-script basis or outright allowing all content on a page.
The text was updated successfully, but these errors were encountered: