Move nsfw to dependencies, remove napi & murmur2 binaries. #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Eskaan
commented
Sep 2, 2022
Eskaan
commented
- Moved native napi binaries out of os specific folders and fully added the public/native folder to the gitignore.
- Added nsfw as dev dependency and added a script to copy it into the natives folder, now it auto-updates and we don't have to keep the binary in the git history.
- The public/native folder is now created automatically.
- Deleted the now no longer used murmur2 binaries.
This reverts commit 0488609.
Eskaan
added
Type: Enhancement
Eskaan
added a commit
that referenced
this pull request
Jan 19, 2023
Eskaan
added a commit
to Eskaan/GDLauncher
that referenced
this pull request
Nov 15, 2023
…evs#1446) * Move nsfw to dependencies, remove tmp napi binaries. * Some fixes * Downgrading nsfw package to working version * Add node-gyp on latest version for Windows build * Revert "Add node-gyp on latest version for Windows build" This reverts commit 0488609. * Add workflow to install node-gyp * Some debugging, tryouts... * Some more debug stuff * Where node plz * Where node the second * Yet another try to fix it * Debuggin & Windoof * Can't find words to describe my feelings * I can't believe it worked * Yet another tryyy * A bit less upgrade
Eskaan
added a commit
to Eskaan/GDLauncher
that referenced
this pull request
Nov 15, 2023
…a-devs#1518) * Try upgrading nsfw * Rebuild nsfw on install * cd into nsfw before rebuilding * Temporarely remove linux&macos builds, fix mistake * Reenable linux&macos checks
Eskaan
added a commit
to Eskaan/GDLauncher
that referenced
this pull request
Nov 17, 2023
…evs#1446) * Move nsfw to dependencies, remove tmp napi binaries. * Some fixes * Downgrading nsfw package to working version * Add node-gyp on latest version for Windows build * Revert "Add node-gyp on latest version for Windows build" This reverts commit 0488609. * Add workflow to install node-gyp * Some debugging, tryouts... * Some more debug stuff * Where node plz * Where node the second * Yet another try to fix it * Debuggin & Windoof * Can't find words to describe my feelings * I can't believe it worked * Yet another tryyy * A bit less upgrade
Eskaan
added a commit
to Eskaan/GDLauncher
that referenced
this pull request
Nov 17, 2023
…a-devs#1518) * Try upgrading nsfw * Rebuild nsfw on install * cd into nsfw before rebuilding * Temporarely remove linux&macos builds, fix mistake * Reenable linux&macos checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.