Update microsoft URI from HTTP to HTTPS - #1513 #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Microsoft URI requires HTTPS.
|
|
|
Yeah I just noticed this today and was already investigating. Seems like you guys were faster here. :) |
2 tasks
|
Happy to lend a hand - even if its only a 1 character change. ;) |
|
Has a release been made with this PR yet? Or how can I make this change locally so I can download packs? |
|
No, I am still fixing some things. |
2 tasks
Closed
Eskaan
pushed a commit
to Eskaan/GDLauncher
that referenced
this pull request
Nov 15, 2023
Eskaan
pushed a commit
to Eskaan/GDLauncher
that referenced
this pull request
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft URI requires HTTPS.
Purpose
Requesting urls from microsoft throws 400 when http. Https solves this.
Approach
force the url to use HTTPS
Open Questions and Pre-Merge TODOs
none