Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Documentation for selecting subprotocols incorrect #625

Closed
agl opened this issue Aug 20, 2020 · 1 comment · Fixed by #627
Closed

[bug] Documentation for selecting subprotocols incorrect #625

agl opened this issue Aug 20, 2020 · 1 comment · Fixed by #627
Assignees
@elithrar
Labels
documentation

Comments

@agl
Copy link

agl commented Aug 20, 2020

Upgrader.Upgrade says:

// The responseHeader is included in the response to the client's upgrade
// request. Use the responseHeader to specify cookies (Set-Cookie) and the
// application negotiated subprotocol (Sec-WebSocket-Protocol).

But that's wrong. The Sec-WebSocket-Protocol header is filtered out from responseHeader and has to come from settting Upgrader.Subprotocols.
@agl agl added the bug Something isn't working label Aug 20, 2020
@elithrar elithrar added documentation and removed bug Something isn't working labels Aug 22, 2020
@elithrar elithrar mentioned this issue Aug 22, 2020
Merged
@elithrar elithrar self-assigned this Aug 22, 2020
@elithrar
Copy link
Contributor

Fixed - thanks @agl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elithrar elithrar

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Docs w.r.t. setting subprotocols gorilla/websocket
2 participants
@elithrar @agl