Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds a model for Orders requests #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adds a model for Orders requests #101

wants to merge 1 commit into from

Conversation

ColinW520
Copy link

Resolves #100

  • adds an Order model with list and create operations.
  • adds a basic spec

I followed existing patterns for the spec; but, would like to see additional context testing for confidence sake. Example:

context 'given valid parameters' do
  it 'returns an Order object' do
  end
en

context 'given invalid/incomplete parameters' do
  it 'returns an Error object' do
  end
end

@jfriedr
Copy link
Contributor

jfriedr commented Aug 10, 2020

Thanks for digging into this. I'll look into what we can do about this context testing and get back to you.

Do you mind sharing what version of ruby you're using?

@ColinW520
Copy link
Author

Thanks @jfriedr! I'm presently on ruby 2.6.6.

Happy to help if needed.

@jfriedr
Copy link
Contributor

jfriedr commented Sep 3, 2020

@ColinW520 apologies for the delay. I needed to take some time off and am still playing a bit of catch up. If you put in a pull request our team can do a quick review and then go through the steps of pushing it to the gems.org repo.

@ColinW520 ColinW520 marked this pull request as ready for review September 14, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

provide an Order model
2 participants
@ColinW520 @jfriedr