Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dgoss sha256 asset for release v0.4.7 #914

Closed
dklimpel opened this issue May 17, 2024 · 4 comments
Closed

Missing dgoss sha256 asset for release v0.4.7 #914

dklimpel opened this issue May 17, 2024 · 4 comments
Labels

Comments

@dklimpel
Copy link
Contributor

dklimpel commented May 17, 2024

Describe the bug

The sha256 checksum (dgoss.sha256) is missing in the assets for release v0.4.7

How To Reproduce

An checksum asset (dgoss.sha256).
Either added afterwards or for the next release.

Actual Behavior

Its' missing

Environment:

  • Github

By the way, there is a release for dgoss, bot not for kgoss and dcgoss.

@dklimpel dklimpel added the bug label May 17, 2024
@dklimpel dklimpel changed the title Missing dgoss sha256 asset s for release v0.4.7 Missing dgoss sha256 asset for release v0.4.7 May 17, 2024
@aelsabbahy
Copy link
Member

By the way, there is a release for dgoss, bot not for kgoss and dcgoss.

Yeah it's a bit tricky, dgoss I maintain, everything else is community added/supported, but I don't maintain it, but I guess technically that's the case with windows/macos too and that's now in releases. 🤔

Also, I think the install.sh installs dgoss from the latest version in git. I think that decision was based on not wanting to cut a Goss release for a minor bash wrapper script change.

Perhaps the whole release lifecycle needs to be re-evaluted l:

  1. What changes trigger a release.
  2. What is considered part of a Goss release
  3. BONUS: Improve installation story for Linux and other OSes

@dklimpel
Copy link
Contributor Author

Yeah it's a bit tricky, dgoss I maintain, everything else is community added/supported, but I don't maintain it.

This makes it clearer.

Than I have added to much changes to:

@aelsabbahy
Copy link
Member

aelsabbahy commented May 18, 2024

It's fine, we can keep them for now.

Before, I didn't release what I didn't maintain, but that changed with windows/macOS support.. so might as well release dcgoss/kgoss.

@dklimpel
Copy link
Contributor Author

I close this. This version will soon be outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants