From 72e91a1ddeb0bfb1a19699b3f5822ca6d731a656 Mon Sep 17 00:00:00 2001 From: Alfred Krohmer Date: Mon, 19 Aug 2024 09:21:39 +0200 Subject: [PATCH] fix: use non-caching client to get pod in `getPodPrivateIP` also in EIP controller --- controllers/eip_controller.go | 7 ++++--- main.go | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/controllers/eip_controller.go b/controllers/eip_controller.go index 2141b4c..e972b38 100644 --- a/controllers/eip_controller.go +++ b/controllers/eip_controller.go @@ -37,8 +37,9 @@ import ( // EIPReconciler reconciles a EIP object type EIPReconciler struct { client.Client - Log logr.Logger - EC2 *ec2.EC2 + NonCachingClient client.Client + Log logr.Logger + EC2 *ec2.EC2 } // +kubebuilder:rbac:groups=aws.k8s.logmein.com,resources=eips,verbs=get;list;watch;create;update;patch;delete @@ -270,7 +271,7 @@ func (r *EIPReconciler) releaseEIP(ctx context.Context, eip *awsv1alpha1.EIP, lo func (r *EIPReconciler) getPodPrivateIP(ctx context.Context, namespace, podName string) (string, error) { pod := &corev1.Pod{} - if err := r.Client.Get(ctx, client.ObjectKey{ + if err := r.NonCachingClient.Get(ctx, client.ObjectKey{ Namespace: namespace, Name: podName, }, pod); err != nil { diff --git a/main.go b/main.go index 2efe3b6..6f897ca 100644 --- a/main.go +++ b/main.go @@ -91,9 +91,10 @@ func main() { } err = (&controllers.EIPReconciler{ - Client: cachingClient, - Log: ctrl.Log.WithName("controllers").WithName("EIP"), - EC2: ec2, + Client: cachingClient, + NonCachingClient: nonCachingClient, + Log: ctrl.Log.WithName("controllers").WithName("EIP"), + EC2: ec2, }).SetupWithManager(mgr) if err != nil { setupLog.Error(err, "unable to create controller", "controller", "EIP")