chore: handle latest version

goto · Dec 9, 2024 · 72330cf · 72330cf
1 parent d52021d
commit 72330cf
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/core/appeal/service.go b/core/appeal/service.go
@@ -1562,6 +1562,7 @@ func getPolicy(a *domain.Appeal, p *domain.Provider, policiesMap map[string]map[
 			}
 
 			dynamicPolicyConfigData = pc.Policy
+			break
 		}
 	}
 
@@ -1570,7 +1571,12 @@ func getPolicy(a *domain.Appeal, p *domain.Provider, policiesMap map[string]map[
 		policyData := strings.Split(dynamicPolicyConfigData, "@")
 		dynamicPolicyConfig.ID = policyData[0]
 		if len(policyData) > 1 {
-			version, err := strconv.Atoi(policyData[1])
+			var version int
+			if policyData[1] == "latest" {
+				version = 0
+			} else {
+				version, err = strconv.Atoi(policyData[1])
+			}
 			if err != nil {
 				return nil, fmt.Errorf("invalid policy version: %w", err)
 			}

diff --git a/core/appeal/service_test.go b/core/appeal/service_test.go
@@ -1642,7 +1642,11 @@ func (s *ServiceTestSuite) TestCreate() {
 					Policies: []*domain.ProviderPolicy{
 						{
 							When:   "$appeal.resource.type == 'dataset'",
-							Policy: "policy_dataset",
+							Policy: "policy_dataset@latest",
+						},
+						{
+							When:   "$appeal.resource.type == 'dataset2'",
+							Policy: "policy_dataset@2",
 						},
 					},
 				},
@@ -1687,7 +1691,7 @@ func (s *ServiceTestSuite) TestCreate() {
 			},
 			{
 				ID:      "policy_table",
-				Version: 1,
+				Version: 2,
 				Steps: []*domain.Step{
 					{
 						Name:     "step_1",