feat(policy): apply dynamic policy #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idilhaq
force-pushed
the
provider_new_dynamic_policies
branch
from
c585c1a to
6f81e89
Compare
idilhaq
force-pushed
the
provider_new_dynamic_policies
branch
from
9a5f0f1 to
161b9f0
Compare
rahmatrhd
reviewed
Dec 2, 2024
rahmatrhd
reviewed
Dec 2, 2024
rahmatrhd
reviewed
Dec 2, 2024
rahmatrhd
reviewed
Dec 2, 2024
idilhaq
force-pushed
the
provider_new_dynamic_policies
branch
from
161b9f0 to
78ee4c8
Compare
idilhaq
force-pushed
the
provider_new_dynamic_policies
branch
from
b18752e to
d52021d
Compare
abhishekv24
previously approved these changes
Dec 9, 2024
abhishekv24
reviewed
Dec 9, 2024
| @@ -3656,6 +3681,9 @@ | |||
| "permissions": { | |||
| "type": "array", | |||
| "items": {} | |||
| }, | |||
| "type": { | |||
There was a problem hiding this comment.
wait, I did not add this but it came up on this PR
this is the proton for policy changes goto/proton#139
and looks like this field was introduced on this PR https://github.com/goto/proton/pull/138/files
tried to rebase but it says it's already updated hmm
There was a problem hiding this comment.
Oh I guess this one got added on proton by gtf but currrently not implemented on our guardian. That's why on my addition of new param, it also got added there. This should be ok for now
There was a problem hiding this comment.
Let’s make sure it doesn’t break anything.
rahmatrhd
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.