-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation test about creating pipeline layout with null bind group layout #4076
base: main
Are you sure you want to change the base?
Conversation
Hi @jzm-intel and @kainino0x , With latest webgpu/types I cannot test PTAL, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional nits but feel free to land with or without!
.combine('bindGroupLayout1', MaybeNullBindGroupLayoutTypes) | ||
.combine('bindGroupLayout2', MaybeNullBindGroupLayoutTypes) | ||
.combine('bindGroupLayout3', MaybeNullBindGroupLayoutTypes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional nit: I think the filter can be a bit simpler if you start out like this:
.combine('bindGroupLayout1', MaybeNullBindGroupLayoutTypes) | |
.combine('bindGroupLayout2', MaybeNullBindGroupLayoutTypes) | |
.combine('bindGroupLayout3', MaybeNullBindGroupLayoutTypes) | |
.expand('bindGroupLayout1', p => p.bindGroupLayoutCount > 1 ? MaybeNullBindGroupLayoutTypes : ['Null']) | |
.expand('bindGroupLayout2', p => p.bindGroupLayoutCount > 2 ? MaybeNullBindGroupLayoutTypes : ['Null']) | |
.expand('bindGroupLayout3', p => p.bindGroupLayoutCount > 3 ? MaybeNullBindGroupLayoutTypes : ['Null']) |
.combine('bindGroupLayout1', MaybeNullBindGroupLayoutTypes) | ||
.combine('bindGroupLayout2', MaybeNullBindGroupLayoutTypes) | ||
.combine('bindGroupLayout3', MaybeNullBindGroupLayoutTypes) | ||
.filter(t => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe:
// Only test cases where at least one of the bind group layouts is null.
const allBGLs = [p.bindGroupLayout0, p.bindGroupLayout1, p.bindGroupLayout2, p.bindGroupLayout3];
const bgls = allBGLs.slice(0, p.bindGroupLayoutCount);
return bgls.includes('Null');
Issue: #4075
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.