Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation test about creating pipeline layout with null bind group layout #4076

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Jiawei-Shao
Copy link
Collaborator

Issue: #4075


Requirements for PR author:

  • [*] All missing test coverage is tracked with "TODO" or .unimplemented().
  • [*] New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • [*] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • [*] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@Jiawei-Shao
Copy link
Collaborator Author

Hi @jzm-intel and @kainino0x ,

With latest webgpu/types I cannot test undefined as a member of GPUPipelineLayoutDescriptor.bindGroupLayouts so I only test null in this PR. I've raised this issue as gpuweb/types#162.

PTAL, thanks!

Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional nits but feel free to land with or without!

Comment on lines +179 to +181
.combine('bindGroupLayout1', MaybeNullBindGroupLayoutTypes)
.combine('bindGroupLayout2', MaybeNullBindGroupLayoutTypes)
.combine('bindGroupLayout3', MaybeNullBindGroupLayoutTypes)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional nit: I think the filter can be a bit simpler if you start out like this:

Suggested change
.combine('bindGroupLayout1', MaybeNullBindGroupLayoutTypes)
.combine('bindGroupLayout2', MaybeNullBindGroupLayoutTypes)
.combine('bindGroupLayout3', MaybeNullBindGroupLayoutTypes)
.expand('bindGroupLayout1', p => p.bindGroupLayoutCount > 1 ? MaybeNullBindGroupLayoutTypes : ['Null'])
.expand('bindGroupLayout2', p => p.bindGroupLayoutCount > 2 ? MaybeNullBindGroupLayoutTypes : ['Null'])
.expand('bindGroupLayout3', p => p.bindGroupLayoutCount > 3 ? MaybeNullBindGroupLayoutTypes : ['Null'])

.combine('bindGroupLayout1', MaybeNullBindGroupLayoutTypes)
.combine('bindGroupLayout2', MaybeNullBindGroupLayoutTypes)
.combine('bindGroupLayout3', MaybeNullBindGroupLayoutTypes)
.filter(t => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe:

// Only test cases where at least one of the bind group layouts is null.
const allBGLs = [p.bindGroupLayout0, p.bindGroupLayout1, p.bindGroupLayout2, p.bindGroupLayout3];
const bgls = allBGLs.slice(0, p.bindGroupLayoutCount);
return bgls.includes('Null');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants