Added comment spec file #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For people that don't know ruby, it's not that explicit that (1), (2) and (3) are annotations and not ruby code. At least when the file is parsed to html. By adding the comment, it will make it more explicit and may save some headaches
|
I came across your article (https://gquintana.github.io/2016/09/07/Testing-Logstash-configuration.html) because I'm trying to find a way to test logstash. Because I'm a newbie in Ruby I didn't realize that those were annotations (I thought it was some weird feature of ruby and/or the logstash gems), so I was bumping my head against a wall trying to find out why it was not working. This is my suggestion to improve it, feel free to ignore/discard if you don't think it's relevant or necessary :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For people that don't know ruby, it's not that explicit that (1), (2) and (3) are annotations and not ruby code.
At least when the file is parsed to html.
By adding the comment, it will make it more explicit and may save some headaches