Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resizer on altair #8603

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Fix resizer on altair #8603

merged 5 commits into from
Jun 25, 2024

Conversation

aliabid94
Copy link
Collaborator

when using altair with gr.Plot, the resizer is not guaranteed to work. It only works when using native plots (gr.LinePlot, gr.BarPlot, gr.ScatterPlot). Made it so resizing logic only applies when the chart type is provided, meaning this is a native plot.

test with altair_plot and native_plots demos/

@aliabid94 aliabid94 requested a review from abidlabs June 25, 2024 05:20
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jun 25, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/fec9eb1bfe339e6710867c86aa6d39e70cbf42e6/gradio-4.36.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@fec9eb1bfe339e6710867c86aa6d39e70cbf42e6#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/fec9eb1bfe339e6710867c86aa6d39e70cbf42e6/gradio-client-1.1.1.tgz

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jun 25, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/plot patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix resizer on altair

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs added the v: patch A change that requires a patch release label Jun 25, 2024
Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the quick fix

@abidlabs
Copy link
Member

let's get this in for the release

@abidlabs abidlabs merged commit affce4c into main Jun 25, 2024
8 checks passed
@abidlabs abidlabs deleted the resize_only_with_native_plots branch June 25, 2024 15:09
This was referenced Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants