Small changes to caching #9438
Merged
Small changes to caching #9438
+22
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/91b1c7099a1aea2bec26da35a98df85434f5a369/gradio-4.44.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@91b1c7099a1aea2bec26da35a98df85434f5a369#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/91b1c7099a1aea2bec26da35a98df85434f5a369/gradio-client-1.6.0-beta.3.tgzUse Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/91b1c7099a1aea2bec26da35a98df85434f5a369/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
abidlabs
commented
Sep 25, 2024
gradio/helpers.py
Outdated
Comment on lines
148
to
149
| elif utils.get_space() and fn is not None and outputs is not None: | ||
| self.cache_examples = True |
There was a problem hiding this comment.
I also got rid of this logic and instead set the GRADIO_CACHE_EXAMPLES env in the Spaces Dockerfile: https://github.com/huggingface-internal/workloads/pull/2379
abidlabs
requested review from
aliabid94,
aliabd,
dawoodkhan82 and
freddyaboulton
freddyaboulton
approved these changes
Sep 26, 2024
gradio/helpers.py
Outdated
| ) | ||
| elif cache_examples == "lazy": | ||
| warnings.warn( | ||
| "The `cache_examples` parameter no longer accepts a value of 'lazy'. To enable lazy caching in " |
There was a problem hiding this comment.
Why not enable lazy caching in this case instead of not caching at all since we're soft deprecating?
There was a problem hiding this comment.
Yes that's fair actually, I'll make the change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from @apolinario (internal link), tweaked the
cache_examplesparameter to throw a warning instead of an exception ifcache_examples="lazy"