Update object detection guide #9456
Open
+506
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/b4e83529f7a715ede0c3af2467ef31d1eafdf750/gradio-4.44.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@b4e83529f7a715ede0c3af2467ef31d1eafdf750#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/b4e83529f7a715ede0c3af2467ef31d1eafdf750/gradio-client-1.6.0-beta.3.tgzUse Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/b4e83529f7a715ede0c3af2467ef31d1eafdf750/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
freddyaboulton
commented
Sep 26, 2024
| @@ -15,6 +15,11 @@ def copy_js_code(root: str | pathlib.Path): | |||
| "playwright-report", | |||
| "workbench", | |||
| "tooltils", | |||
| "component-test", | |||
There was a problem hiding this comment.
We don't need to move any of these directories to _frontend_code directory.
There was a problem hiding this comment.
Related to some custom component fixing clean-up I'll do in a different PR
| @@ -1243,7 +1243,10 @@ async def component_server( | |||
| status_code=status.HTTP_404_NOT_FOUND, | |||
| detail="Function not found.", | |||
| ) | |||
| return fn(body.data) | |||
| if inspect.iscoroutinefunction(fn): | |||
There was a problem hiding this comment.
So that you can use async functions in @server decorator. Needed for webrtc component.
freddyaboulton
requested review from
aliabid94,
pngwn,
abidlabs,
aliabd,
dawoodkhan82,
hannahblair and
whitphx
abidlabs
reviewed
Sep 27, 2024
Comment on lines
+49
to
+55
| gr.HTML( | ||
| """ | ||
| <h3 style='text-align: center'> | ||
| <a href='https://arxiv.org/abs/2405.14458' target='_blank'>arXiv</a> | <a href='https://github.com/THU-MIG/yolov10' target='_blank'>github</a> | ||
| </h3> | ||
| """ | ||
| ) |
There was a problem hiding this comment.
I'd suggest removing to keep the demo simpler, but up to you
Suggested change
| gr.HTML( | |
| """ | |
| <h3 style='text-align: center'> | |
| <a href='https://arxiv.org/abs/2405.14458' target='_blank'>arXiv</a> | <a href='https://github.com/THU-MIG/yolov10' target='_blank'>github</a> | |
| </h3> | |
| """ | |
| ) |
abidlabs
reviewed
Sep 27, 2024
There was a problem hiding this comment.
I'd suggest renaming the guide to include webrtc in the title, to make it easier to find, currently shows up as:
abidlabs
reviewed
Sep 27, 2024
|
|
||
| ## Setting up the Model | ||
|  |
There was a problem hiding this comment.
Video seems to be broken: https://gradio-4u4cvrf1d-hugging-face.vercel.app/main/guides/object-detection-from-webcam
abidlabs
reviewed
Sep 27, 2024
|
|
||
| * The user's webcam will be both an input and an output. That way, the user will only see their stream with the detected objects. | ||
| * We'll use the `time_limit` and `stream_every` parameters of the `stream` event. The `time_limit` parameter will mean that we'll process each user's stream for that amount of time. In a multi-user setting, such as on Spaces, this means that after this period of time, the next user in the queue will be able to use the demo. The `stream_every` function will control how frequently the webcam stream is sent to the server. | ||
| 1. Use the `WebRTC` custom component to ensure input and output are sent to/from the server with WebRTC. |
There was a problem hiding this comment.
Link to the webrtc custom component here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the webcam detection guide to use WebRTC and yolo-v10
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh