Skip to content

Commit

Permalink
remove irrelevant TODO comment
Browse files Browse the repository at this point in the history
  • Loading branch information
rfratto committed Oct 30, 2023
1 parent 9083b26 commit 9ca3e83
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions component/discovery/discovery.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ func (t *DistributedTargets) Get() []Target {

res := make([]Target, 0, (len(t.targets)+1)/len(t.cluster.Peers()))

// TODO(@tpaschalis): Make sure OpReadWrite is the correct operation;
// eg. this determines how clustering behaves when nodes are shutting down.
for _, tgt := range t.targets {
peers, err := t.cluster.Lookup(shard.StringKey(tgt.NonMetaLabels().String()), 1, shard.OpReadWrite)
if err != nil {
Expand Down
2 changes: 0 additions & 2 deletions component/loki/source/podlogs/reconciler.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,6 @@ func distributeTargets(c cluster.Cluster, targets []*kubetail.Target) []*kubetai

res := make([]*kubetail.Target, 0, (len(targets)+1)/len(c.Peers()))

// TODO(@tpaschalis): Make sure OpReadWrite is the correct operation;
// eg. this determines how clustering behaves when nodes are shutting down.
for _, target := range targets {
peers, err := c.Lookup(shard.StringKey(target.Labels().String()), 1, shard.OpReadWrite)
if err != nil {
Expand Down

0 comments on commit 9ca3e83

Please sign in to comment.