Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotation popup is shown as only a small empty box (elasticsearch) #2563

Closed
lark opened this issue Aug 20, 2015 · 1 comment
Closed

Annotation popup is shown as only a small empty box (elasticsearch) #2563

lark opened this issue Aug 20, 2015 · 1 comment
Labels
area/annotations type/bug
Milestone
2.5

Comments

@lark
Copy link

lark commented Aug 20, 2015

Version: official grafana 2.1.1 debian amd64 package.

It seems that this is caused by annotation title field contains email address. Chrome developer console spits errors such as

Error: [$sanitize:badparse] The sanitizer was unable to parse the following block of html: <EMAIL_ADDRESS_HERE> blah blah

It works in 1.8.1. There is no requirement or change mentioned in doc that title and text field must be in html sanitized format.
@torkelo torkelo added this to the 2.2 milestone Aug 21, 2015
@torkelo
Copy link
Member

torkelo commented Aug 21, 2015

thanks for reporting this, fixed in master!

donh pushed a commit to donh/grafana that referenced this issue Nov 12, 2015
@torkelo
fix(annotations): Fixed issue when html sanitizer failes for title to…
60d380d 
… annotation body, now fallbacks to html escaping title and text, fixes grafana#2563
donh pushed a commit to donh/grafana that referenced this issue Nov 12, 2015
@torkelo
fix(annotations): Fixed issue when html sanitizer failes for title to…
89e21ab 
… annotation body, now fallbacks to html escaping title and text, fixes grafana#2563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/annotations type/bug
Projects
None yet
Milestone
2.5
Development

No branches or pull requests
2 participants
@torkelo @lark