Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clean K6 object when test has failed or finished OK #276

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

aaguilartablada
Copy link

To solve the issue #275

Álvaro Aguilar added 2 commits August 22, 2023 13:27
Signed-off-by: Álvaro Aguilar <95039001@lidl.de>
Signed-off-by: Álvaro Aguilar <95039001@lidl.de>
@CLAassistant
Copy link

CLAassistant commented Aug 22, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ aaguilartablada
❌ Álvaro Aguilar


Álvaro Aguilar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Signed-off-by: Álvaro Aguilar <alvaro.aguilar@scrm.lidl>
Copy link
Contributor

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yorugac
Copy link
Collaborator

yorugac commented Aug 22, 2024

Hi @aaguilartablada, apologies for such a terrible delay! Your PR never got a signed CLA: I remember thinking "let's wait until they sign before reviewing" and then apparently, I forgot about this PR since there were no new notifications 😅

Would you like to continue working on it? All contributors must sign the CLA though.

@vipul-mykaarma
Copy link

will this pr be merged ? asking since my load test had 10 runners and some of them failed. but this led to no pods being cleanup after test duration inspite of having having the cleanup: post option in yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants