From 82b678dfeb243cd5da392ee207611992aa3b5cfc Mon Sep 17 00:00:00 2001 From: Cristiano Ventura Date: Wed, 25 Sep 2024 11:07:23 -0400 Subject: [PATCH 1/3] docs: add pull request template --- .github/pull_request_template.md | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..8f5b0da6 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,28 @@ + + +## Description + + + +## How to Test + + + +## Checklist + +- [ ] I have performed a self-review of my code. +- [ ] I have added tests for my changes. +- [ ] I have commented on my code, particularly in hard-to-understand areas. + + +## Screenshots (if appropriate): + +## Related PR(s)/Issue(s) + + + + + + + + From 86fa0058b2d3843a41fe7660e49efae3ed8b731e Mon Sep 17 00:00:00 2001 From: Cristiano Ventura Date: Wed, 25 Sep 2024 11:08:23 -0400 Subject: [PATCH 2/3] docs: add link to k6 studio issues --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 8f5b0da6..845f197d 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -19,7 +19,7 @@ ## Related PR(s)/Issue(s) - + From 195a9f4ab19779fab99852f91ec5ea8d8b7c7542 Mon Sep 17 00:00:00 2001 From: Cristiano Ventura Date: Wed, 25 Sep 2024 11:52:37 -0400 Subject: [PATCH 3/3] docs: add checks for lint and tests --- .github/pull_request_template.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 845f197d..5da48e4a 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -12,6 +12,8 @@ - [ ] I have performed a self-review of my code. - [ ] I have added tests for my changes. +- [ ] I have run linter locally (`npm run lint`) and all checks pass. +- [ ] I have run tests locally (`npm test`) and all tests pass. - [ ] I have commented on my code, particularly in hard-to-understand areas.