Add scrape_protocols to prometheus.scrape Components for Native Histograms
#932
+72
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeamusGrafana
requested review from
skl,
nevermind89x,
petewall and
jewbetcha
skl
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial attempt to add support for scraping Native Histograms with the PrometheusProto (Protobuf) Scrape Protocol.
See https://grafana.com/docs/mimir/latest/send/native-histograms/#scrape-and-send-native-histograms-with-grafana-alloy for more context and here for the Arguments in Alloy.
This will allow Native Histograms to be correctly scraped and then sent to the Metrics Backend when Enabled.
Closes #881
In a future update the ability to set the Scrape Protocols via a Value may be needed, but this should work for now.