From 1d3b0be15bb0a388c0249b7be49a77f4667f2c3d Mon Sep 17 00:00:00 2001 From: Robert Fratto Date: Wed, 13 Nov 2019 09:56:27 -0500 Subject: [PATCH] helm: update default terminationGracePeriodSeconds to 4800 (#1257) Users that run Loki using the Helm chart may not modify the value for terminationGracePeriodSeconds that allows Loki enough time to flush all of its data. If Loki is forcefully terminated by Kubernetes during a flush, missing data or an unhealthy ingester in the ring in microservices mode can occur. This commit changes the grace period to 4800 seconds, the value used in the Jsonnet code. --- production/helm/loki-stack/Chart.yaml | 2 +- production/helm/loki/Chart.yaml | 2 +- production/helm/loki/values.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/production/helm/loki-stack/Chart.yaml b/production/helm/loki-stack/Chart.yaml index 087f10150b2eb..431b2766f8f01 100644 --- a/production/helm/loki-stack/Chart.yaml +++ b/production/helm/loki-stack/Chart.yaml @@ -1,6 +1,6 @@ apiVersion: "v1" name: loki-stack -version: 0.19.0 +version: 0.19.1 appVersion: v0.4.0 kubeVersion: "^1.10.0-0" description: "Loki: like Prometheus, but for logs." diff --git a/production/helm/loki/Chart.yaml b/production/helm/loki/Chart.yaml index a1f86419aba65..f04deb10c0461 100644 --- a/production/helm/loki/Chart.yaml +++ b/production/helm/loki/Chart.yaml @@ -1,6 +1,6 @@ apiVersion: "v1" name: loki -version: 0.17.1 +version: 0.17.2 appVersion: v0.4.0 kubeVersion: "^1.10.0-0" description: "Loki: like Prometheus, but for logs." diff --git a/production/helm/loki/values.yaml b/production/helm/loki/values.yaml index ef9086cc96b38..d6c1521cbc40b 100644 --- a/production/helm/loki/values.yaml +++ b/production/helm/loki/values.yaml @@ -154,7 +154,7 @@ serviceAccount: create: true name: -terminationGracePeriodSeconds: 30 +terminationGracePeriodSeconds: 4800 ## Tolerations for pod assignment ## ref: https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/