Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt centralised limits code for Loki #1229

Closed
tomwilkie opened this issue Nov 5, 2019 · 3 comments
Closed

Adapt centralised limits code for Loki #1229

tomwilkie opened this issue Nov 5, 2019 · 3 comments
Assignees
@pracucci
Labels
keepalive An issue or PR that will be kept alive and never marked as stale.

Comments

@tomwilkie
Copy link
Contributor

tomwilkie commented Nov 5, 2019 •
edited by pracucci
Loading

There are two Loki limits which we need to centralize:

  • IngestionRate (based on this Cortex PR once merged)
  • MaxStreamsPerUser
@tomwilkie
Copy link
Contributor Author

(Sorry if this has already been done - feel free to close if so)

@stale
Copy link

stale bot commented Dec 5, 2019

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Dec 5, 2019
@pracucci pracucci added the keepalive An issue or PR that will be kept alive and never marked as stale. label Dec 5, 2019
@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Dec 5, 2019
@pracucci
Copy link
Contributor

Closed by #1493 and #1486.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pracucci pracucci

Labels
keepalive An issue or PR that will be kept alive and never marked as stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomwilkie @pracucci