Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker driver image should publish master image or it should be removed from dockerhub #2440

Closed
owen-d opened this issue Jul 28, 2020 · 1 comment

Comments

@owen-d
Copy link
Member

owen-d commented Jul 28, 2020

I'm of the opinion that keeping :master up to date is a good idea.

from #2420

@slim-bean
Copy link
Collaborator

slim-bean commented Jul 28, 2020

I deleted the master tag.

We already push a master-xxxxxx tag with every commit to master, master isn't really a first class tag name in docker world so I don't know if it really adds any value if it's the same as the :latest tag?

I would suggest anyone who wants the bleeding edge use latest or pick a specific master-xxxxxx tag

cyriltovena added a commit to cyriltovena/loki that referenced this issue Jun 11, 2021
* Implement swift storage client.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Pass nil registrerer.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

* Make lint happy.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

Co-authored-by: Peter Štibraný <peter.stibrany@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants