ingester.max-chunk-age #1558
Merged
ingester.max-chunk-age #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
commented
Jan 21, 2020
| @@ -246,7 +246,10 @@ func (i *Ingester) shouldFlushChunk(chunk *chunkDesc) bool { | |||
| } | |||
|
|
|||
| if time.Since(chunk.lastUpdated) > i.cfg.MaxChunkIdle { | |||
| chunk.closed = true | |||
There was a problem hiding this comment.
This was removed from shouldFlushChunk for a few reasons:
- It's only previous reference,
collectChunksToFlush, was immediately followed by duplicate closing code: https://github.com/grafana/loki/blob/2179ed1018133b54ad7f018fff5f57e9699b9655/pkg/ingester/flush.go#L230-L232 - It's now used by
sweepStreamto support deduplicating logic and this new location should not alter thechunk.closedfield shouldFlushChunkdoesn't sound like it should mutate the underlying*chunkDesc
rfratto
reviewed
Jan 21, 2020
slim-bean
approved these changes
Jan 22, 2020
There was a problem hiding this comment.
Looks good @owen-d , you'll need to rebase on master and fix your helm chart versions for loki and loki-stack, as well as probably figure out something to do different with your changelog entry.
Otherwise lets get this merged!
owen-d
force-pushed
the
feature/ingester-max-chunk-age
branch
from
5b52e66
to
bbf6694
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Introduces
ingester.max-chunk-agewhich specifies the maximum chunk age before it's cut. This allows us to enforce absolute time bounds on chunks, not just idle timeouts.First half of #1550