removes duplicate logRangeExprExt grammar #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1651 +/- ##
========================================
+ Coverage 61.69% 61.8% +0.1%
========================================
Files 109 109
Lines 8308 8308
========================================
+ Hits 5126 5135 +9
+ Misses 2786 2780 -6
+ Partials 396 393 -3
|
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* cache table info for bigtable tables in tablemanager Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * Add expiration to the bigtable table cache Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * fix order of adding table to cache Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * refactor based on review comments Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * add ListTables comment Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Simplifies the logql grammar by removing an unnecessary
logRangeExprExttype which can be represented asLogRangeExpr. Without this change there are yaccshift/reduceerrors as it's impossible to tell betweenselector DURATIONandlogExpr DURATION.