Sign helm package with GPG. #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add GPG to the build image and fixes dlv not pinned (this was causing issue using latest 1.4). Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1864 +/- ##
==========================================
- Coverage 64.84% 64.82% -0.03%
==========================================
Files 125 125
Lines 9423 9423
==========================================
- Hits 6110 6108 -2
- Misses 2886 2887 +1
- Partials 427 428 +1
|
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
|
Last step is to provide the public key in this repo. I’ll add it on Monday |
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
|
Ready for review. |
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
* Sign helm package with GPG. Also add GPG to the build image and fixes dlv not pinned (this was causing issue using latest 1.4). Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Regen drone config. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Testing CI. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Test CI. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Include .prov files for charts. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Revert testing changes. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> * Add public GPG key for verifying helm charts. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add GPG to the build image and fixes dlv not pinned (this was causing issue using latest 1.4).
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com
Fixes #1720
Going to need to uncomment the filter on tag-master once it works.