Fix flaky promtail test #1865
Merged
Fix flaky promtail test #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks ! Could you give some details on what was the problem ? I'll take a look tmw. |
|
@cyriltovena I am still digging at it. I am not able to reproduce the error. |
|
Does that change fixes the race ? I think it should. |
|
It will not fix the race exactly. I am using map. So, it won't verify the order. It will just check if the entry is present in map. |
|
Would be nice if you could also fix the race in that PR. |
|
Sure. I have pinged this issue in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix flaky promtail test which was causing few test failures.
Which issue(s) this PR fixes:
Fixes #1520