Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adding a config change in release 1.4 upgrade doc, updating readme with new doc links #1887

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

slim-bean
Copy link
Collaborator

Signed-off-by: Edward Welch edward.welch@grafana.com

Updating readme with links to new docs

Signed-off-by: Edward Welch <edward.welch@grafana.com>
@codecov-io
Copy link

Codecov Report

Merging #1887 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1887      +/-   ##
==========================================
- Coverage   64.67%   64.61%   -0.06%     
==========================================
  Files         125      125              
  Lines        9477     9477              
==========================================
- Hits         6129     6124       -5     
- Misses       2924     2927       +3     
- Partials      424      426       +2     
Impacted Files Coverage Δ
pkg/promtail/targets/filetarget.go 68.71% <0.00%> (-1.85%) ⬇️
pkg/logql/evaluator.go 90.69% <0.00%> (-0.59%) ⬇️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slim-bean slim-bean merged commit 6b9f82d into master Apr 2, 2020
@slim-bean slim-bean deleted the release-docs-update branch April 2, 2020 13:47
@@ -39,25 +39,30 @@ Once you have Promtail, Loki, and Grafana running, continue with our [Getting
Started Guide](https://github.com/grafana/loki/tree/v1.3.0/docs/getting-started/README.md) to get up and running with
querying logs.

## Upgrading

[Upgrading Loki](https://github.com/grafana/loki/blob/master/docs/operations/upgrade.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Upgrading Loki](https://github.com/grafana/loki/blob/master/docs/operations/upgrade.md)
Please refer to our [Upgrading Loki](https://github.com/grafana/loki/blob/master/docs/operations/upgrade.md) guide for details on how to upgrade from one version to another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants