Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki: add -print-config-stderr flag to dump loki's runtime config to stderr #2336

Merged
merged 3 commits into from
Jul 11, 2020

Conversation

slim-bean
Copy link
Collaborator

It's difficult and time consuming to track down configuration especially when trying to figure out what the default value for a config which wasn't strictly defined is.

This flag dumps the entire loki config object as yaml to stderr just before it's passed to the starting operation of Loki

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2020

Codecov Report

Merging #2336 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2336      +/-   ##
==========================================
- Coverage   61.28%   61.26%   -0.03%     
==========================================
  Files         158      159       +1     
  Lines       12812    12827      +15     
==========================================
+ Hits         7852     7858       +6     
- Misses       4367     4370       +3     
- Partials      593      599       +6     
Impacted Files Coverage Δ
pkg/util/config.go 0.00% <0.00%> (ø)
pkg/promtail/targets/file/tailer.go 73.86% <0.00%> (-4.55%) ⬇️
pkg/promtail/targets/file/filetarget.go 68.67% <0.00%> (-1.81%) ⬇️
pkg/logql/evaluator.go 92.13% <0.00%> (-0.41%) ⬇️
pkg/promtail/positions/positions.go 60.71% <0.00%> (+13.39%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTTM

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 10, 2020
@slim-bean slim-bean merged commit 0b59960 into master Jul 11, 2020
@slim-bean slim-bean deleted the config-dump branch July 11, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants