Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker driver doc #2420

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Fix docker driver doc #2420

merged 1 commit into from
Jul 28, 2020

Conversation

petuhovskiy
Copy link
Contributor

Had some trouble today understanding why loki driver stopped recognizing log-opts after upgrade. It was, until I figured out that grafana/loki-docker-driver:master image is actually 1 year old, and I should use latest instead.

This PR fixes Upgrading section by replacing incorrect tag in snippet.

By the way, consider the option of updating/deleting master tag in docker hub registry. It can eliminate this kind of problem.

Updated docker tag for grafana/loki-docker-driver in Upgrading doc section
@CLAassistant
Copy link

CLAassistant commented Jul 25, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #2420 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2420      +/-   ##
==========================================
- Coverage   61.58%   61.58%   -0.01%     
==========================================
  Files         160      160              
  Lines       13590    13590              
==========================================
- Hits         8370     8369       -1     
  Misses       4597     4597              
- Partials      623      624       +1     
Impacted Files Coverage Δ
pkg/promtail/targets/file/tailer.go 76.13% <0.00%> (-2.28%) ⬇️
pkg/logql/evaluator.go 92.47% <0.00%> (-0.41%) ⬇️
pkg/promtail/targets/file/filetarget.go 70.48% <0.00%> (+1.80%) ⬆️

@owen-d
Copy link
Member

owen-d commented Jul 28, 2020

Thanks, you're totally right on all accounts. We keep master-<sha> tags currently if you're looking for a specific build, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants