Promtail: force the log level on any Loki Push API target servers to match Promtail's log level. #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tail's log level.
Codecov Report
@@ Coverage Diff @@
## master #2475 +/- ##
==========================================
- Coverage 62.97% 62.95% -0.03%
==========================================
Files 162 162
Lines 13988 13992 +4
==========================================
- Hits 8809 8808 -1
- Misses 4494 4497 +3
- Partials 685 687 +2
|
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* Regex set optimisation when looking series in ingester Similar to cortexproject/cortex#2446 Super useful for templated grafana dashboards which send matchers such as =~"a|b|c|d|e" Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Add CHANGELOG entry Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Add benchmark for set optimisation Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't love this solution, but I also don't love passing the log level through all the constructors just for the push target.
This seemed a bit better?