Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonnet/ruler #2560

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Jsonnet/ruler #2560

merged 2 commits into from
Aug 27, 2020

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Aug 27, 2020

Adds jsonnet configurations for the ruler. In favor of simplicity, defaults to a gcs bucket which can be overridden.

@codecov-commenter
Copy link

Codecov Report

Merging #2560 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2560      +/-   ##
==========================================
+ Coverage   62.98%   62.99%   +0.01%     
==========================================
  Files         168      168              
  Lines       14879    14879              
==========================================
+ Hits         9371     9373       +2     
+ Misses       4762     4761       -1     
+ Partials      746      745       -1     
Impacted Files Coverage Δ
pkg/logql/evaluator.go 92.88% <0.00%> (+0.40%) ⬆️

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@owen-d owen-d merged commit f6f83fe into grafana:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants